Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refreshFormData to update the data correctly using form->fill #15514

Merged

Conversation

borjajimnz
Copy link
Contributor

Description

As described in #14222 this will fix the issue by applying the data through $this->form->fill($data);

Visual changes

https://youtu.be/gQMdgHefjeU

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label Feb 5, 2025
@danharrin danharrin added this to the v3 milestone Feb 5, 2025
Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix #13232? Also please apply to ViewRecord

@borjajimnz
Copy link
Contributor Author

Yes, @danharrin, this fixes both #13232 and #14222

It has also been applied to the ViewRecord. Check it out below:
https://youtu.be/2OXXPOeCfCE

Best regards

@borjajimnz borjajimnz requested a review from danharrin February 5, 2025 22:13
@danharrin danharrin merged commit 229437c into filamentphp:3.x Feb 6, 2025
10 checks passed
@danharrin
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants